owner(ticdc): close the ddl sink to fix the resource leak#12678
Conversation
ti-chi-bot
Bot
added
release-note
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes a noisy log statement in shared_client.go and updates ddl_sink.go to properly close the DDL sink before setting it to nil during retries. However, a potential data race and nil-pointer panic was identified in ddl_sink.go because s.sink is accessed and modified concurrently without synchronization; introducing a mutex is recommended to protect these operations.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
ti-chi-bot
Bot
added
needs-1-more-lgtm
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kennytm, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
size/M
|
/test all |
ti-chi-bot
Bot
added
cherry-pick-approved
|
/retest |
1 similar comment
|
/retest |
|
https://do.pingcap.net/jenkins/job/pingcap/job/tiflow/job/release-7.5/job/ghpr_verify/992/console 🤔 |
|
/test pull-verify |
|
/retest |
|
/test all |
Codecov Report❌ Patch coverage is Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-7.5 #12678 +/- ##
================================================
Coverage ? 57.4739%
================================================
Files ? 860
Lines ? 128432
Branches ? 0
================================================
Hits ? 73815
Misses ? 49204
Partials ? 5413 🚀 New features to boost your workflow:
|
|
/test pull-cdc-integration-kafka-test |
1 similar comment
|
/test pull-cdc-integration-kafka-test |
|
/retest |
|
/test pull-cdc-integration-pulsar-test |
|
/retest |
1 similar comment
|
/retest |
4 participants
What problem does this PR solve?
Issue Number: ref #12666
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note